linux-kernel - Re: start switching sysfs attributes to expose the seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bd7d03e-c2d0-0cb5-76fc-f5601324a18d@acm.org>
Date:   Mon, 13 Sep 2021 19:53:03 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Christoph Hellwig <hch@....de>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>,
        linux-block@...r.kernel.org, linux-xfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: start switching sysfs attributes to expose the seq_file

On 9/13/21 09:46, Greg Kroah-Hartman wrote:
> On Mon, Sep 13, 2021 at 09:39:56AM -0700, Bart Van Assche wrote:
>> On 9/12/21 10:41 PM, Christoph Hellwig wrote:
>>> Al pointed out multiple times that seq_get_buf is highly dangerous as
>>> it opens up the tight seq_file abstractions to buffer overflows.  The
>>> last such caller now is sysfs.
>>>
>>> This series allows attributes to implement a seq_show method and switch
>>> the block and XFS code as users that I'm most familiar with to use
>>> seq_files directly after a few preparatory cleanups.  With this series
>>> "leaf" users of sysfs_ops can be converted one at at a time, after that
>>> we can move the seq_get_buf into the multiplexers (e.g. kobj, device,
>>> class attributes) and remove the show method in sysfs_ops and repeat the
>>> process until all attributes are converted.  This will probably take a
>>> fair amount of time.
>>
>> Hi Christoph,
>>
>> Thanks for having done this work. In case you would need it, some time ago
>> I posted the following sysfs patch but did not receive any feedback:
>> "[PATCH] kernfs: Improve lockdep annotation for files which implement mmap"
>> (https://lore.kernel.org/linux-kernel/20191004161124.111376-1-bvanassche@acm.org/).
>>
> 
> That was from back in 2019, sorry I must have missed it.
> 
> Care to rebase and resend it if it is still needed?

Hi Greg,

I think that patch is still relevant. It removes some ugly code from 
sysfs. I will rebase, retest and resend it.

Thanks,

Bart.