linux-kernel - Re: [PATCH 4/4 v0.5] sched/umcg: add Documentation/userspace-api/umcg.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPNVh5eY68FSWEFwQuqN69rx2gvAn6T04SvV6MA=uEhtdy-Uyw@mail.gmail.com>
Date:   Tue, 14 Sep 2021 09:57:46 -0700
From:   Peter Oskolkov <posk@...gle.com>
To:     Tao Zhou <tao.zhou@...ux.dev>
Cc:     Peter Oskolkov <posk@...k.io>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        Paul Turner <pjt@...gle.com>, Ben Segall <bsegall@...gle.com>,
        Andrei Vagin <avagin@...gle.com>, Jann Horn <jannh@...gle.com>,
        Thierry Delisle <tdelisle@...terloo.ca>
Subject: Re: [PATCH 4/4 v0.5] sched/umcg: add Documentation/userspace-api/umcg.rst

On Tue, Sep 14, 2021 at 9:34 AM Tao Zhou <tao.zhou@...ux.dev> wrote:

[...]

> > +- worker to worker context switch:
> > +  ``W1:RUNNING+W2:IDLE => W1:IDLE+W2:RUNNING``:
> > +
> > +  - in the userspace, in the context of W1 running:
> > +
> > +    - ``W2:IDLE => W2:RUNNING|LOCKED`` (mark W2 as running)
> > +    - ``W1:RUNNING => W1:IDLE|LOCKED`` (mark self as idle)
> > +    - ``W2.next_tid := W1.next_tid; S.next_tid := W2.next_tid``
>                                                         ^^^^^^^^
> W2.next_tid is a server. S.next_tid should be a worker; say:
>
>   S.next_tid := W2.tid

You are definitely right here. I'll fix the doc in the next patchset.