linux-kernel - Re: [PATCH] mtd: rawnand: intel: Fix potential buffer overflow in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210914173916.301250-1-miquel.raynal@bootlin.com>
Date:   Tue, 14 Sep 2021 19:39:16 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Evgeny Novikov <novikov@...ras.ru>,
        Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Ramuthevar Vadivel Murugan 
        <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Kirill Shilimanov <kirill.shilimanov@...wei.com>,
        Anton Vasilyev <vasilyev@...ras.ru>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] mtd: rawnand: intel: Fix potential buffer overflow in probe

On Fri, 2021-09-03 at 08:26:53 UTC, Evgeny Novikov wrote:
> ebu_nand_probe() read the value of u32 variable "cs" from the device
> firmware description and used it as the index for array ebu_host->cs
> that can contain MAX_CS (2) elements at most. That could result in
> a buffer overflow and various bad consequences later.
> 
> Fix the potential buffer overflow by restricting values of "cs" with
> MAX_CS in probe.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Fixes: 0b1039f016e8 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC")
> Signed-off-by: Evgeny Novikov <novikov@...ras.ru>
> Co-developed-by: Kirill Shilimanov <kirill.shilimanov@...wei.com>
> Signed-off-by: Kirill Shilimanov <kirill.shilimanov@...wei.com>
> Co-developed-by: Anton Vasilyev <vasilyev@...ras.ru>
> Signed-off-by: Anton Vasilyev <vasilyev@...ras.ru>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel