linux-kernel - Re: [PATCH] drm/rockchip: cdn-dp-core: Fix cdn_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36ff9f69-2c77-90ca-e2b5-f237f94a95a0@infradead.org>
Date:   Mon, 13 Sep 2021 21:15:29 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Palmer Dabbelt <palmer@...belt.com>, heiko@...ech.de
Cc:     hjc@...k-chips.com, airlied@...ux.ie, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-team@...roid.com, Palmer Dabbelt <palmerdabbelt@...gle.com>
Subject: Re: [PATCH] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused
 warning

On 1/14/21 11:40 PM, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@...gle.com>
> 
> cdn_dp_resume is only used under PM_SLEEP, and now that it's static an
> unused function warning is triggered undner !PM_SLEEP.  This
> conditionally enables the function to avoid the warning.
> 
> Fixes: 7c49abb4c2f8 ("drm/rockchip: cdn-dp-core: Make cdn_dp_core_suspend/resume static")
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
> ---
>   drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index a4a45daf93f2..063a60d213ba 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1121,6 +1121,7 @@ static int cdn_dp_suspend(struct device *dev)
>   	return ret;
>   }
>   
> +#ifdef CONFIG_PM_SLEEP
>   static int cdn_dp_resume(struct device *dev)
>   {
>   	struct cdn_dp_device *dp = dev_get_drvdata(dev);
> @@ -1133,6 +1134,7 @@ static int cdn_dp_resume(struct device *dev)
>   
>   	return 0;
>   }
> +#endif
>   
>   static int cdn_dp_probe(struct platform_device *pdev)
>   {
> 

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested


Is someone going to merge this patch from January?

thanks.
-- 
~Randy