linux-kernel - Re: [PATCH v2] scsi: bsg: Fix device unregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <163159443486.11082.13793603628764579473.b4-ty@oracle.com>
Date:   Tue, 14 Sep 2021 00:40:49 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     linux-block@...r.kernel.org, linux-scsi@...r.kernel.org,
        Zenghui Yu <yuzenghui@...wei.com>, linux-kernel@...r.kernel.org
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        johan@...nel.org, fujita.tomonori@....ntt.co.jp, hch@....de,
        gregkh@...uxfoundation.org, wanghaibin.wang@...wei.com,
        axboe@...nel.dk
Subject: Re: [PATCH v2] scsi: bsg: Fix device unregistration

On Sat, 11 Sep 2021 18:53:06 +0800, Zenghui Yu wrote:

> We use device_initialize() to take refcount for the device but forget to
> put_device() on device teardown, which ends up leaking private data of the
> driver core, dev_name(), etc. This is reported by kmemleak at boot time if
> we compile kernel with DEBUG_TEST_DRIVER_REMOVE.
> 
> Note that adding the missing put_device() is _not_ sufficient to fix device
> unregistration. As we don't provide the .release() method for device, which
> turned out to be typically wrong and will be complained loudly by the
> driver core.
> 
> [...]

Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: bsg: Fix device unregistration
      https://git.kernel.org/mkp/scsi/c/1a0db7744e45

-- 
Martin K. Petersen	Oracle Linux Engineering