linux-kernel - Re: [PATCH RESEND v3 10/13] blk-mq: Add blk_mq_alloc_map_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4803363-4502-2b05-d1ac-846d14537435@suse.de>
Date:   Tue, 14 Sep 2021 07:48:41 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, axboe@...nel.dk
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        ming.lei@...hat.com, linux-scsi@...r.kernel.org
Subject: Re: [PATCH RESEND v3 10/13] blk-mq: Add blk_mq_alloc_map_and_rqs()

On 9/13/21 5:12 PM, John Garry wrote:
> Add a function to combine allocating tags and the associated requests,
> and factor out common patterns to use this new function.
> 
> Some functions only call blk_mq_alloc_map_and_rqs() now, but more
> functionality will be added later to those functions.
> 
> Also make blk_mq_alloc_rq_map() and blk_mq_alloc_rqs() static since they
> are only used in blk-mq.c, and finally rename some functions for
> conciseness and consistency with other function names:
> - __blk_mq_alloc_map_and_{request -> rqs}()
> - blk_mq_alloc_{map_and_requests -> set_map_and_rqs}()
> 
> Suggested-by: Ming Lei <ming.lei@...hat.com>
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>   block/blk-mq-sched.c | 15 +++--------
>   block/blk-mq-tag.c   |  9 +------
>   block/blk-mq.c       | 62 +++++++++++++++++++++++++-------------------
>   block/blk-mq.h       |  9 ++-----
>   4 files changed, 42 insertions(+), 53 deletions(-)
> Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@...e.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer