linux-kernel - Re: [PATCH v2] xen-blkback: Remove needless request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YUBWNkD3lECHrhAp@MacBook-Air-de-Roger.local>
Date:   Tue, 14 Sep 2021 09:58:46 +0200
From:   Roger Pau Monné <roger.pau@...rix.com>
To:     Xu Wang <vulab@...as.ac.cn>
CC:     <Damien.LeMoal@....com>, <konrad.wilk@...cle.com>,
        <axboe@...nel.dk>, <xen-devel@...ts.xenproject.org>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] xen-blkback: Remove needless request_queue NULL
 pointer check

On Fri, Sep 10, 2021 at 03:59:18AM +0000, Xu Wang wrote:
> The request_queue pointer returned from bdev_get_queue() shall
> never be NULL, so the null check is unnecessary, just remove it.

There are other places in the code where the return of bdev_get_queue
is checked to not be NULL, like __blkdev_issue_discard. Should those
also be changed?

> Signed-off-by: Xu Wang <vulab@...as.ac.cn>

Acked-by: Roger Pau Monné <roger.pau@...rix.com>

Regards, Roger.