linux-kernel - RE: [PATCH] scsi: ufs: ufshpb: Use proper power management API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB6575EFE1EED8D52FFA81BC5BFCDA9@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Tue, 14 Sep 2021 08:41:44 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "daejun7.park@...sung.com" <daejun7.park@...sung.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "bvanassche@....org" <bvanassche@....org>,
        Keoseong Park <keosung.park@...sung.com>,
        "huobean@...il.com" <huobean@...il.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: ufshpb: Use proper power management API

 
> In ufshpb, pm_runtime_{get,put}_sync() are used to avoid unwanted runtime
> suspend during query requests. In commit b294ff3e3449 ("scsi: ufs: core:
> Enable power management for wlun") has been modified to use
> ufshcd_rpm_{get,put}_sync() APIs.
> 
> This patch has been modified to use these APIs in HPB module.
> 
> Signed-off-by: Daejun Park <daejun7.park@...sung.com>
Reviewed-by: Avri Altman <avri.altman@....com>


> ---
>  drivers/scsi/ufs/ufshpb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
> index 02fb51ae8b25..9ea639bf6a59 100644
> --- a/drivers/scsi/ufs/ufshpb.c
> +++ b/drivers/scsi/ufs/ufshpb.c
> @@ -2650,11 +2650,11 @@ static int ufshpb_get_lu_info(struct ufs_hba *hba,
> int lun,
> 
>         ufshcd_map_desc_id_to_length(hba, QUERY_DESC_IDN_UNIT, &size);
> 
> -       pm_runtime_get_sync(hba->dev);
> +       ufshcd_rpm_get_sync(hba);
>         ret = ufshcd_query_descriptor_retry(hba,
> UPIU_QUERY_OPCODE_READ_DESC,
>                                             QUERY_DESC_IDN_UNIT, lun, 0,
>                                             desc_buf, &size);
> -       pm_runtime_put_sync(hba->dev);
> +       ufshcd_rpm_put_sync(hba);
> 
>         if (ret) {
>                 dev_err(hba->dev,
> @@ -2877,10 +2877,10 @@ void ufshpb_get_dev_info(struct ufs_hba *hba, u8
> *desc_buf)
>         if (version == HPB_SUPPORT_LEGACY_VERSION)
>                 hpb_dev_info->is_legacy = true;
> 
> -       pm_runtime_get_sync(hba->dev);
> +       ufshcd_rpm_get_sync(hba);
>         ret = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_READ_ATTR,
>                 QUERY_ATTR_IDN_MAX_HPB_SINGLE_CMD, 0, 0,
> &max_hpb_single_cmd);
> -       pm_runtime_put_sync(hba->dev);
> +       ufshcd_rpm_put_sync(hba);
> 
>         if (ret)
>                 dev_err(hba->dev, "%s: idn: read max size of single hpb cmd query
> request failed",
> --
> 2.25.1