linux-kernel - Re: [PATCH v4 2/2] coresight: Update comments for removing cs_etm_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210914100847.GD1538480@leoy-ThinkPad-X240s>
Date:   Tue, 14 Sep 2021 18:08:47 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Mike Leach <mike.leach@...aro.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] coresight: Update comments for removing
 cs_etm_find_snapshot()

On Tue, Sep 14, 2021 at 10:27:26AM +0100, Suzuki Kuruppassery Poulose wrote:

[...]

> > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > index d23c7690f29a..ce14eb83925c 100644
> > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > @@ -1573,9 +1573,8 @@ tmc_update_etr_buffer(struct coresight_device *csdev,
> >   	/*
> >   	 * In snapshot mode we simply increment the head by the number of byte
> > -	 * that were written.  User space function  cs_etm_find_snapshot() will
> > -	 * figure out how many bytes to get from the AUX buffer based on the
> > -	 * position of the head.
> > +	 * that were written.  User space will figure out how many bytes to get
> > +	 * from the AUX buffer based on the position of the head.
> >   	 */
> >   	if (etr_perf->snapshot)
> >   		handle->head += size;
> > 
> 
> 
> Thanks for the revised patch, I have queued both the patches.

Cool, and thanks Suzuki!