linux-kernel - Re: [PATCH v4 15/18] staging: r8188eu: hal: Clean up usbctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210914122021.GC2116@kadam>
Date:   Tue, 14 Sep 2021 15:20:21 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Michael Straube <straube.linux@...il.com>,
        Pavel Skripkin <paskripkin@...il.com>
Subject: Re: [PATCH v4 15/18] staging: r8188eu: hal: Clean up
 usbctrl_vendorreq()

On Tue, Sep 14, 2021 at 01:18:01PM +0200, Fabio M. De Francesco wrote:
> On Tuesday, September 14, 2021 11:24:05 AM CEST Dan Carpenter wrote:
> > On Mon, Sep 13, 2021 at 08:09:59PM +0200, Fabio M. De Francesco wrote:
> > > Clean up usbctrl_vendorreq () in usb_ops_linux.c because some
> > > of its code will be reused in this series. This cleanup is in
> > > preparation for shortening the call chains of rtw_read{8,16,32}()
> > > and rtw_write{8,16,32,N}(). More insights about the reasons why at
> > > https://lore.kernel.org/lkml/5319192.FrU0QrjFp7@localhost.localdomain/ 
> > > 
> > 
> > This commit message is quite bad.
> > 
> > This patch has nothing to do with reusing the code or shortening call
> > chains.
> 
> It has to do, in a certain sense. Let me explain please...

I guess I can see that all this stuff is related in your mind, but next
time please leave it out.  Keep the commit messages as simple to
understand as possible.

Just say you are cleaning up the function.  That's a simple motivation.
A good motivation.

regards,
dan carpenter