linux-kernel - Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Sep 2021 15:39:39 +0200
From:   Sebastian Döring 
        <moralapostel+linuxkernel@...il.com>
To:     Michael Riesch <michael.riesch@...fvision.net>
Cc:     Ivan Babrou <ivan@...n.computer>, sashal@...nel.org,
        alexandre.torgue@...s.st.com, davem@...emloft.net,
        joabreu@...opsys.com, kuba@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com,
        mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
        peppe.cavallaro@...com, wens@...nel.org
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings

Hi Michael,

I guess looking for a better or more ideal solution sounds good, but
sorry if this is impertinent, as it's coming from a mostly uninvolved
3rd party: This is affects a kernel that is labeled as "stable". It
seems extremely unacceptable to break ethernet support for boards like
the rockpro64, which are used largely in a headless fashion, when the
offending commit has already been identified.

I don't expect a stable kernel release to completely break my hardware
and then see people not immediately applying a workaround patch. It
seems strange. I'm not fond of having to fix things through serial
console and hunting through mailing lists to figure out what's going
on. I'd only expect this for -rc kernels.

Just my two cents.

Best regards,
Sebastian

Am Di., 14. Sept. 2021 um 12:09 Uhr schrieb Michael Riesch
<michael.riesch@...fvision.net>:
>
> Hello Ivan,
>
> On 9/14/21 3:10 AM, Ivan Babrou wrote:
> > Is it possible to revert the patch from the 5.14 and 5.15 as well?
> > I've tried upgrading my rockpro64 board from 5.13 to 5.15-rc1 and
> > ended up bisecting the issue to this commit like the others. It would
> > be nice to spare others from this exercise.
>
> For what it is worth we believe that there is a different issue with the
> dwmac-rk driver that was obscured by calling pm_runtime_get_sync()
> early. Investigation in progress -- I hope that we can achieve a proper
> solution before we have to revert the revert.
>
> Best regards,
> Michael