linux-kernel - Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210914135217.GD4434@sirena.org.uk>
Date:   Tue, 14 Sep 2021 14:52:17 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Stephen Boyd <sboyd@...nel.org>, alexandre.belloni@...tlin.com,
        Michael Turquette <mturquette@...libre.com>,
        Ludovic.Desroches@...rochip.com, lee.jones@...aro.org,
        linux-clk@...r.kernel.org, linux-rtc@...r.kernel.org,
        Russell King <linux@...linux.org.uk>, o.rempel@...gutronix.de,
        andy.shevchenko@...il.com, aardelean@...iqon.com,
        linux-pwm@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Jonathan.Cameron@...wei.com, linux-arm-kernel@...ts.infradead.org,
        a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, wsa@...nel.org,
        thierry.reding@...il.com, kernel@...gutronix.de,
        akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
        Claudiu.Beznea@...rochip.com
Subject: Re: About clk maintainership [Was: Re: [PULL] Add variants of
 devm_clk_get for prepared and enabled clocks enabled clocks]

On Tue, Sep 14, 2021 at 03:22:56PM +0200, Uwe Kleine-König wrote:
> On Thu, Aug 05, 2021 at 05:26:16PM -0700, Stephen Boyd wrote:

> > This proves why this topic is always contentious. It's too easy to
> > blindly convert drivers to get the clk and leave it enabled forever and
> > then they never use power management. The janitors win and nobody else.

> If the janitors win and nobody else looses anything, this is fine for
> me. And if in the future someone turns up who cares enough to improve
> the converted drivers to a more efficient clock usage, they will
> probably not stop their efforts just because then the driver uses
> devm_clk_get_enabled.

The patterns that concern me are people either blindly converting to
devm without checking for other usage and causing problems as a result
(some of the janitorial stuff is done very mechanically) or thinking
it's important to keep devm_ used (or not thinking through the
interaction) and trying to do that while doing something more active.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)