linux-kernel - Re: [PATCH] regulator: rtq6752: Enclose 'enable' gpio control by enable flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADiBU3-xzopQxPSnwb=LnRhBBgOYyEttS7Jksg2izGv6W5BCAw@mail.gmail.com>
Date:   Tue, 14 Sep 2021 22:11:01 +0800
From:   ChiYuan Huang <u0084500@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        lkml <linux-kernel@...r.kernel.org>,
        cy_huang <cy_huang@...htek.com>
Subject: Re: [PATCH] regulator: rtq6752: Enclose 'enable' gpio control by
 enable flag

Hi,

Mark Brown <broonie@...nel.org> 於 2021年9月14日 週二 下午10:08寫道：
>
> On Tue, Sep 14, 2021 at 09:58:32PM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@...htek.com>
> >
> > Fix 'enable' gpio control logic if it's specified.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> > ---
> > This patch is to prevent the logic error from the below cases.
> >
> > 1. All off and both are sequentially controlled to be on.
> > The 'enable' gpio control block to be called twice including the delay time.
> >
> > 2. Both are on and one is preparing to be off.
> > The 'enable' gpio control low before register cache is configured to be true.
>
> This should be in the actual commit message.
OK, I'll send the v2 and add all comments into the commit message.
Thx.