linux-kernel - Re: [PATCH] net/alacritech: Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <707ca3c3-f42a-d7f7-b52c-829d8e243c87@gmx.de>
Date:   Wed, 15 Sep 2021 23:20:40 +0200
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/alacritech: Make use of the helper function
 dev_err_probe()


Hi,

On 15.09.21 at 16:57, Cai Huoqing wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> And using dev_err_probe() can reduce code size, and simplify the code.
>
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>  drivers/net/ethernet/alacritech/slicoss.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index 696517eae77f..170ff8c77983 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -1743,10 +1743,8 @@ static int slic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	int err;
>
>  	err = pci_enable_device(pdev);
> -	if (err) {
> -		dev_err(&pdev->dev, "failed to enable PCI device\n");
> -		return err;
> -	}
> +	if (err)
> +		return dev_err_probe(&pdev->dev, err, "failed to enable PCI device\n");
>
>  	pci_set_master(pdev);
>  	pci_try_set_mwi(pdev);
>

in which case does pci_enable_device() ever return -EPROBE_DEFER?

Regards,
Lino