linux-kernel - Re: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XfN9YxTveoOVUFoJjq1_R_8mdvDQnF+DOVvkNaosnKN0g@mail.gmail.com>
Date:   Wed, 15 Sep 2021 03:07:18 +0000
From:   Joel Stanley <joel@....id.au>
To:     Ryan Chen <ryan_chen@...eedtech.com>
Cc:     Stephen Boyd <sboyd@...nel.org>,
        "Claudiu.Beznea@...rochip.com" <Claudiu.Beznea@...rochip.com>,
        "andrew@...id.au" <andrew@...id.au>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>
Subject: Re: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula

On Wed, 15 Sept 2021 at 02:52, Ryan Chen <ryan_chen@...eedtech.com> wrote:
>
> > -----Original Message-----
> > From: Stephen Boyd <sboyd@...nel.org>
> > Sent: Wednesday, September 15, 2021 9:17 AM
> > To: Claudiu.Beznea@...rochip.com; Ryan Chen
> > <ryan_chen@...eedtech.com>; andrew@...id.au; joel@....id.au;
> > linux-clk@...r.kernel.org; linux-kernel@...r.kernel.org;
> > mturquette@...libre.com
> > Subject: RE: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula
> >
> > Quoting Ryan Chen (2021-09-12 22:31:46)
> > > > > +               if (hwstrap & BIT(10))
> > > > > +                       m = 0x5F;
> > > > > +               else {
> > > > > +                       if (hwstrap & BIT(8))
> > > >
> > > > You may write it directly:
> > > >                 else if (hwstrap & BIT(8))
> > > >
> > > Hello,
> > >         Like I commit message M = SCU500[10] ? 0x5F : SCU500[8] ? 0xBF :
> > SCU200[12:0]
> > >         it need keep from register read, if BIT(8)/BIT(10) not 1.
> > >
> >
> > I don't get it. The review comment was that the else { if (...) can be collapsed
> > into an else if (..) What does commit message have to do with it?
> Sorry for confuse.
> Or do you mean like following modification?
>
>                if (hwstrap & BIT(10))
>                        m = 0x5F;
>                else if (hwstrap & BIT(8))
>                        m = 0xBF;

Yep!

Take a look at my review of v1. I wrote it out there.