linux-kernel - Re: [PATCH v1 4/4] PM / devfreq: tegra30: Check whether clk_round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fa66405-883a-3653-eb5d-3cd7eee07a0a@gmail.com>
Date:   Wed, 15 Sep 2021 12:51:11 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Cc:     linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v1 4/4] PM / devfreq: tegra30: Check whether
 clk_round_rate() returns zero rate

Hi,

On 21. 9. 13. 오전 3:44, Dmitry Osipenko wrote:
> EMC clock is always-on and can't be zero. Check whether clk_round_rate()
> returns zero rate and error out if it does. It can return zero if clock
> tree isn't initialized properly.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>   drivers/devfreq/tegra30-devfreq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index d83fdc2713ed..65ecf17a36f4 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -891,9 +891,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
>   		return err;
>   
>   	rate = clk_round_rate(tegra->emc_clock, ULONG_MAX);
> -	if (rate < 0) {
> +	if (rate <= 0) {
>   		dev_err(&pdev->dev, "Failed to round clock rate: %ld\n", rate);
> -		return rate;
> +		return rate ?: -EINVAL;
>   	}
>   
>   	tegra->max_freq = rate / KHZ;
> 

Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi