linux-kernel - RE: [PATCH v6 1/2] scsi: ufs: Probe for temperature notification support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR04MB6575D4234BAE8E0537F5E400FCDB9@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Wed, 15 Sep 2021 05:52:16 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Guenter Roeck <linux@...ck-us.net>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bart Van Assche <bvanassche@....org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Bean Huo <beanhuo@...ron.com>
Subject: RE: [PATCH v6 1/2] scsi: ufs: Probe for temperature notification
 support

> > +static int ufs_hwmon_read(struct device *dev, enum
> hwmon_sensor_types type, u32 attr, int channel,
> > +                       long *val)
> > +{
> > +     struct ufs_hwmon_data *data = dev_get_drvdata(dev);
> > +     struct ufs_hba *hba = data->hba;
> > +     int err;
> > +
> > +     if (type != hwmon_temp)
> > +             return 0;
> > +
> 
> Was that there before ? Dorry, I didn't notice.
> First of all, strictly speaking it is unnecessary, but if it is there
> it should return an error. Plus, checking the type here but not in
> the write function is a bit inconsistent.
Will remove.  Done.

> > +static int ufs_hwmon_write(struct device *dev, enum
> hwmon_sensor_types type, u32 attr, int channel,
> > +                        long val)
> > +{
> > +     struct ufs_hwmon_data *data = dev_get_drvdata(dev);
> > +     struct ufs_hba *hba = data->hba;
> > +     int err = 0;
> 
> Still unnecessary.
Done.