[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <36fe241f845a27b52509274d007948b1@codeaurora.org>
Date: Wed, 15 Sep 2021 11:56:19 +0530
From: okukatla@...eaurora.org
To: Stephen Boyd <swboyd@...omium.org>
Cc: Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
bjorn.andersson@...aro.org, devicetree@...r.kernel.org,
evgreen@...gle.com, georgi.djakov@...aro.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
mdtipton@...eaurora.org, sibis@...eaurora.org,
saravanak@...gle.com, seansw@....qualcomm.com, elder@...aro.org,
linux-pm@...r.kernel.org, linux-arm-msm-owner@...r.kernel.org,
okukatla=codeaurora.org@...eaurora.org
Subject: Re: [v7 3/3] arm64: dts: qcom: sc7280: Add EPSS L3 interconnect
provider
On 2021-09-15 10:35, okukatla@...eaurora.org wrote:
> On 2021-09-04 00:36, Stephen Boyd wrote:
>> Quoting Odelu Kukatla (2021-08-20 04:23:41)
>>> Add Epoch Subsystem (EPSS) L3 interconnect provider node on SC7280
>>> SoCs.
>>>
>>> Signed-off-by: Odelu Kukatla <okukatla@...eaurora.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 11 +++++++++++
>>> 1 file changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> index 53a21d0..cf59b47 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> @@ -1848,6 +1848,17 @@
>>> };
>>> };
>>>
>>> + epss_l3: interconnect@...90000 {
>>> + compatible = "qcom,sc7280-epss-l3";
>>> + reg = <0 0x18590000 0 1000>,
>>
>> Is this supposed to be 0x1000?
>>
> No, This is 1000 or 0x3E8.
We have mapped only required registers for L3 scaling, 1000/0x3E8 is
suffice.
But i will update it to 0x1000 in next revision so that entire clock
domain region-0 is mapped.
>>> + <0 0x18591000 0 0x100>,
>>> + <0 0x18592000 0 0x100>,
>>> + <0 0x18593000 0 0x100>;
>>> + clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc
>>> GCC_GPLL0>;
>>> + clock-names = "xo", "alternate";
>>> + #interconnect-cells = <1>;
>>> + };
>>> +
>>> cpufreq_hw: cpufreq@...91000 {
>>> compatible = "qcom,cpufreq-epss";
>>> reg = <0 0x18591100 0 0x900>,
>>> --
>>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>>> Forum,
>>> a Linux Foundation Collaborative Project
>>>
Powered by blists - more mailing lists