linux-kernel - Re: [PATCH net-next v2] net: phy: at803x: add support for qca 8327 internal phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210915072733.1494-1-dqfext@gmail.com>
Date:   Wed, 15 Sep 2021 15:27:33 +0800
From:   DENG Qingfang <dqfext@...il.com>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rosen Penev <rosenp@...il.com>
Subject: Re: [PATCH net-next v2] net: phy: at803x: add support for qca 8327 internal phy

On Tue, Sep 14, 2021 at 02:33:45PM +0200, Ansuel Smith wrote:
> +}, {
> +	/* QCA8327 */
> +	.phy_id = QCA8327_PHY_ID,
> +	.phy_id_mask = QCA8K_PHY_ID_MASK,
> +	.name = "QCA PHY 8327",
> +	/* PHY_GBIT_FEATURES */
> +	.probe = at803x_probe,
> +	.flags = PHY_IS_INTERNAL,
> +	.config_init = qca83xx_config_init,
> +	.soft_reset = genphy_soft_reset,

How about setting .suspend and .resume? Without these, the PHY cannot be
powered down/up administratively (via ip link set xxx down/up).
See commit 93100d6817b0.

Off-topic: When is .soft_reset called? The MediaTek PHY driver seems to work
fine without it.

> +	.get_sset_count = at803x_get_sset_count,
> +	.get_strings = at803x_get_strings,
> +	.get_stats = at803x_get_stats,
>  }, };