linux-kernel - Re: [PATCH -next] irqdomain: fix overflow error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pmtab7no.ffs@tglx>
Date:   Wed, 15 Sep 2021 09:49:15 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Bixuan Cui <cuibixuan@...wei.com>, linux-kernel@...r.kernel.org
Cc:     maz@...nel.org, john.wanghui@...wei.com
Subject: Re: [PATCH -next] irqdomain: fix overflow error

On Wed, Sep 15 2021 at 10:03, Bixuan Cui wrote:
> On 2021/9/14 19:56, Thomas Gleixner wrote:
>
> And kernel/irq/irqdomain.c
> struct irq_domain *irq_domain_create_simple(struct fwnode_handle *fwnode,
>                                             unsigned int size,
>                                             unsigned int first_irq,
>                                             const struct irq_domain_ops *ops,
>                                             void *host_data)
> {
>         struct irq_domain *domain;
>
>         domain = __irq_domain_add(fwnode, size, size, 0, ops, host_data);
>
> All 'size' passed to __irq_domain_add() are unsigned int.
>
> So I think it's more appropriate to replace it with unsigned int.

Appropriate is not really a technical reason. Making the code consistent
is.

But that has nothing to do with the completely bogus compiler warning in
the changelog you provided.

Thanks,

        tglx