linux-kernel - RE: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163166864956.763609.8140689140101809508@swboyd.mtv.corp.google.com>
Date:   Tue, 14 Sep 2021 18:17:29 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Claudiu.Beznea@...rochip.com, Ryan Chen <ryan_chen@...eedtech.com>,
        andrew@...id.au, joel@....id.au, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, mturquette@...libre.com
Subject: RE: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula

Quoting Ryan Chen (2021-09-12 22:31:46)
> > > +               if (hwstrap & BIT(10))
> > > +                       m = 0x5F;
> > > +               else {
> > > +                       if (hwstrap & BIT(8))
> > 
> > You may write it directly:
> >                 else if (hwstrap & BIT(8))
> > 
> Hello,
>         Like I commit message M = SCU500[10] ? 0x5F : SCU500[8] ? 0xBF : SCU200[12:0]
>         it need keep from register read, if BIT(8)/BIT(10) not 1.
>         

I don't get it. The review comment was that the else { if (...) can be
collapsed into an else if (..) What does commit message have to do with
it?