linux-kernel - Re: [PATCH] kernel/power: Remove blk_status_to_errno in hib_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hBOzx=p+4t0KrnzfhapBaUkRzeuRKkY-oX=U4qwey-9Q@mail.gmail.com>
Date:   Wed, 15 Sep 2021 14:18:31 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Falla Coulibaly <fallacoulibalyz@...il.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel/power: Remove blk_status_to_errno in hib_wait_io

On Wed, Aug 18, 2021 at 11:48 PM Falla Coulibaly
<fallacoulibalyz@...il.com> wrote:
>
> blk_status_to_errno doesn't appear to perform extra work besides
> converting blk_status_t to integer. This patch removes that unnecessary
> conversion as the return type of the function is blk_status_t.
>
> Signed-off-by: Falla Coulibaly <fallacoulibalyz@...il.com>
> ---
>  kernel/power/swap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
> index 3cb89baebc79..9ec418955556 100644
> --- a/kernel/power/swap.c
> +++ b/kernel/power/swap.c
> @@ -306,7 +306,7 @@ static blk_status_t hib_wait_io(struct hib_bio_batch *hb)
>          * a plug will flush the plug list before sleeping.
>          */
>         wait_event(hb->wait, atomic_read(&hb->count) == 0);
> -       return blk_status_to_errno(hb->error);
> +       return hb->error;
>  }
>
>  /*
> --

Applied as 5.16 material, thanks!