linux-kernel - Re: [PATCH] regulators: fix typo in Kconfig and max8973-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210915131525.GA12513@sirena.org.uk>
Date:   Wed, 15 Sep 2021 14:15:25 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Ramona Alexandra Nechita <ramona.nechita@...log.com>
Cc:     linux-kernel@...r.kernel.org, lgirdwood@...il.com
Subject: Re: [PATCH] regulators: fix typo in Kconfig and max8973-regulator

On Wed, Sep 15, 2021 at 02:06:27PM +0300, Ramona Alexandra Nechita wrote:
> MAX8973 is supposed to be MAX8973A. Kconfig and the
> initial comment of max8973-regulator.c were modified
> accordingly.

It is?

>  config REGULATOR_MAX8973

Why not update the Kconfig symbol as well?  If there's a danger of
collisions that's probably the main thing people will be using.

> -	tristate "Maxim MAX8973 voltage regulator "
> +	tristate "Maxim MAX8973A voltage regulator "

There's an extra space there while you're fixing stuff up.

> @@ -1,7 +1,7 @@
>  /*
>   * max8973-regulator.c -- Maxim max8973
>   *
> - * Regulator driver for MAXIM 8973 DC-DC step-down switching regulator.
> + * Regulator driver for MAXIM 8973A DC-DC step-down switching regulator.

What about the first line?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)