linux-kernel - Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUH9dg01Mtk+kO+C@kroah.com>
Date:   Wed, 15 Sep 2021 16:04:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tom Rix <trix@...hat.com>
Cc:     mdf@...nel.org, hao.wu@...el.com, linux-kernel@...r.kernel.org,
        linux-fpga@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer

On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
> 
> On 9/14/21 11:58 AM, Greg KH wrote:
> > [note, you got the maintainer's email address wrong on your cc: line
> >   I fixed it up...]
> > 
> > On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@...hat.com wrote:
> > > From: Tom Rix <trix@...hat.com>
> > > 
> > > I am the maintainer of the fpga/ subsystem for both the kernel and
> > > userspace for Red Hat.  I have been an active reviewer and contributor
> > > on for public fpga/ subsystem for the last year.  I would like to
> > > help out more.
> > > 
> > > Since I am paid to do this work, change the status to Supported.
> > > 
> > > Signed-off-by: Tom Rix <trix@...hat.com>
> > > ---
> > >   MAINTAINERS | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 04fa4edf100b83..0443d7ab826659 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
> > >   FPGA MANAGER FRAMEWORK
> > >   M:	Moritz Fischer <mdf@...nel.org>
> > > -R:	Tom Rix <trix@...hat.com>
> > > +M:	Tom Rix <trix@...hat.com>
> > >   L:	linux-fpga@...r.kernel.org
> > > -S:	Maintained
> > > +S:	Supported
> > >   W:	http://www.rocketboards.org
> > >   Q:	http://patchwork.kernel.org/project/linux-fpga/list/
> > >   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
> > > -- 
> > > 2.26.3
> > > 
> > Traditionally existing maintainers are the ones that add new
> > maintainers, it's not something that you just submit a patch for hoping
> > it will be accepted.
> > 
> > What has changed since the last time you asked to do this?
> 
> Because public and private requests have gone unanswered for so long, it is
> unclear if Moritz is still maintaining the subsystem.

He is, as is evident by the patches I accept from him each merge.

> The nearly year old xrt patchset has been pending for 6 weeks with minor
> changes to one patch out of 14 needing reviews.

Code quality is not the maintainer's job, it's the developer's, so the
age and number of reviews is not any indication.

> The standard release patchset, which needs an opinion has on an api change,
> has been outstanding for 8 weeks.

Have a pointer to it?

> If maintainership depends on an approving maintainter, what happens when the
> approving maintainer has left ?

Vacations happen in the summer.  I've talked to Moritz many times, and
all is well here.

greg k-h