[<prev] [next>] [day] [month] [year] [list]
Message-ID: <2776109.MaXvng3DlT@kista>
Date: Wed, 15 Sep 2021 18:31:20 +0200
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: Dang Huynh <danct12@...root.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Maxime Ripard <mripard@...nel.org>,
Chen-Yu Tsai <wens@...e.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] arm64: dts: allwinner: pinetab: Add HDMI support
Dne sreda, 15. september 2021 ob 07:47:31 CEST je Dang Huynh napisal(a):
> On Wednesday, September 15, 2021 3:26:51 AM +07 Jernej Škrabec wrote:
> > > +&simplefb_hdmi {
> > > + vcc-hdmi-supply = <®_dldo1>;
> >
> > You have to set status to okay here.
Sorry, this is actually the job of bootloader, so it's all good.
> >
> > With that fixed, you can add:
No fixing needed for R-b tag.
> > Reviewed-by: Jernej Skrabec <jernej.skrabec@...il.com>
> >
> > Best regards,
> > Jernej
> >
>
> Is it really needed? The DE2 HDMI driver can be loaded and make this pretty
> much obsolete.
DE2 and HDMI driver could read current settings from that node and implement
flicker free transition. However, that's not supported yet. Another use case is
to optimize kernel size to minimum for storing it in SPI flash by removing DRM
driver if simplefb is good enough.
Anyway, patch looks good. Thanks!
Best regards,
Jernej
Powered by blists - more mailing lists