linux-kernel - Re: [PATCH] selftests: be sure to make khdr before other targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f193721-39fd-bcb1-1e14-253c60ab4961@linuxfoundation.org>
Date:   Wed, 15 Sep 2021 10:37:48 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Li Zhijian <lizhijian@...fujitsu.com>, shuah@...nel.org,
        linux-kselftest@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Philip Li <philip.li@...el.com>,
        kernel test robot <lkp@...el.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: be sure to make khdr before other targets

On 9/15/21 7:45 AM, Li Zhijian wrote:
> LKP/0Day reported some building errors about kvm, and errors message
> are not always same:
> - lib/x86_64/processor.c:1083:31: error: ‘KVM_CAP_NESTED_STATE’ undeclared
> (first use in this function); did you mean ‘KVM_CAP_PIT_STATE2’?
> - lib/test_util.c:189:30: error: ‘MAP_HUGE_16KB’ undeclared (first use
> in this function); did you mean ‘MAP_HUGE_16GB’?
> 
> Although kvm relies on the khdr, they still be built in parallel when -j
> is specified. In this case, it will cause compiling errors.
> 
> Here we mark target khdr as NOTPARALLEL to make it be always built
> first.
> 
> CC: Philip Li <philip.li@...el.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Li Zhijian <lizhijian@...fujitsu.com>
> ---
>   tools/testing/selftests/lib.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 7ee911355328..5074b01f2a29 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -48,6 +48,7 @@ ARCH		?= $(SUBARCH)
>   # When local build is done, headers are installed in the default
>   # INSTALL_HDR_PATH usr/include.
>   .PHONY: khdr
> +.NOTPARALLEL:
>   khdr:
>   ifndef KSFT_KHDR_INSTALL_DONE
>   ifeq (1,$(DEFAULT_INSTALL_HDR_PATH))
> 

Thank you for the fix. Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/
fixes branch.

thanks,
-- Shuah