linux-kernel - Re: [PATCH v3] kernel/sched: Fix sched_fork() access an invalid sched_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUIyFdrS3VVfgZhB@slm.duckdns.org>
Date:   Wed, 15 Sep 2021 07:49:09 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Zhang Qiao <zhangqiao22@...wei.com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] kernel/sched: Fix sched_fork() access an invalid
 sched_task_group

On Wed, Sep 15, 2021 at 02:40:30PM +0800, Zhang Qiao wrote:
...
> Between cgroup_can_fork() and cgroup_post_fork(), the cgroup
> membership and thus sched_task_group can't change. So update
> child's sched_task_group at sched_post_fork() and move task_fork()
> and __set_task_cpu() (where accees the sched_task_group) from
> sched_fork() to sched_post_fork().
> 
> Fixes: 8323f26ce342 ("sched: Fix race in task_group")
> Signed-off-by: Zhang Qiao <zhangqiao22@...wei.com>

>From cgroup side,

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun