linux-kernel - Re: [PATCH v3 16/30] ABI: sysfs-bus-soundwire-slave: use wildcards on What definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9a379f0a-e076-844c-fb5d-130359e36754@linux.intel.com>
Date:   Thu, 16 Sep 2021 11:36:33 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jonathan Corbet <corbet@....net>, Vinod Koul <vkoul@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 16/30] ABI: sysfs-bus-soundwire-slave: use wildcards on
 What definitions



On 9/16/21 3:59 AM, Mauro Carvalho Chehab wrote:
> An "N" upper letter is not a wildcard, nor can easily be identified
> by script, specially since the USB sysfs define things like.
> bNumInterfaces. Use, instead, <N>, in order to let script/get_abi.pl
> to convert it into a Regex.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

I also realized that we have a similar with the 'master' case

more sysfs-bus-soundwire-master
What:		/sys/bus/soundwire/devices/sdw-master-N/revision
		/sys/bus/soundwire/devices/sdw-master-N/clk_stop_modes
		/sys/bus/soundwire/devices/sdw-master-N/clk_freq
		/sys/bus/soundwire/devices/sdw-master-N/clk_gears
		/sys/bus/soundwire/devices/sdw-master-N/default_col
		/sys/bus/soundwire/devices/sdw-master-N/default_frame_rate
		/sys/bus/soundwire/devices/sdw-master-N/default_row
		/sys/bus/soundwire/devices/sdw-master-N/dynamic_shape
		/sys/bus/soundwire/devices/sdw-master-N/err_threshold
		/sys/bus/soundwire/devices/sdw-master-N/max_clk_freq

If there is an update we should modify this as well for consistency with
sdw-master-<N>?

> ---
>  .../ABI/testing/sysfs-bus-soundwire-slave     | 60 +++++++++----------
>  1 file changed, 30 insertions(+), 30 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-soundwire-slave b/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> index d324aa0b678f..fbf55834dfee 100644
> --- a/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> +++ b/Documentation/ABI/testing/sysfs-bus-soundwire-slave
> @@ -64,37 +64,37 @@ Description:	SoundWire Slave Data Port-0 DisCo properties.
>  		Data port 0 are used by the bus to configure the Data Port 0.
>  
>  
> -What:		/sys/bus/soundwire/devices/sdw:.../dpN_src/max_word
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/min_word
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/words
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/type
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/max_grouping
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/simple_ch_prep_sm
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/ch_prep_timeout
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/imp_def_interrupts
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/min_ch
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/max_ch
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/channels
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/ch_combinations
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/max_async_buffer
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/block_pack_mode
> -		/sys/bus/soundwire/devices/sdw:.../dpN_src/port_encoding
> +What:		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_word
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/min_word
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/words
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/type
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_grouping
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/simple_ch_prep_sm
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/ch_prep_timeout
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/imp_def_interrupts
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/min_ch
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_ch
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/channels
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/ch_combinations
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/max_async_buffer
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/block_pack_mode
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_src/port_encoding
>  
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/max_word
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/min_word
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/words
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/type
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/max_grouping
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/simple_ch_prep_sm
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/ch_prep_timeout
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/imp_def_interrupts
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/min_ch
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/max_ch
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/channels
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/ch_combinations
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/max_async_buffer
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/block_pack_mode
> -		/sys/bus/soundwire/devices/sdw:.../dpN_sink/port_encoding
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_word
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/min_word
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/words
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/type
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_grouping
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/simple_ch_prep_sm
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/ch_prep_timeout
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/imp_def_interrupts
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/min_ch
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_ch
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/channels
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/ch_combinations
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/max_async_buffer
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/block_pack_mode
> +		/sys/bus/soundwire/devices/sdw:.../dp<N>_sink/port_encoding
>  
>  Date:		May 2020
>  
>