linux-kernel - Re: [PATCH v2] perf test: Workload test of metric and metricgroups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7bbc59b-794f-2675-a044-1e3a58ad1495@huawei.com>
Date:   Thu, 16 Sep 2021 08:41:17 +0100
From:   John Garry <john.garry@...wei.com>
To:     Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        "Namhyung Kim" <namhyung@...nel.org>,
        Jin Yao <yao.jin@...ux.intel.com>,
        <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <eranian@...gle.com>
Subject: Re: [PATCH v2] perf test: Workload test of metric and metricgroups

On 16/09/2021 07:05, Ian Rogers wrote:
> Test every metric and metricgroup with 'true' as a workload.
> 
> Signed-off-by: Ian Rogers<irogers@...gle.com>

Reviewed-by: John Garry <john.garry@...wei.com>

Note that I also had a local test for pmu events:
for e in `$PERF list --raw-dump pmu`; do
   echo "Testing $e"
   result=$($PERF stat -v -e "$e" perf bench internals synthesize)
   if [[ "$result" =~ "$e" ]]; then
     echo "Event not printed: $e"
     exit 1
   fi
done

Is there any value in upstreaming this? I could not see same already 
there. Or else make your new script generic, so that it accepts an 
argument whether to test events or metrics or metricgroups