linux-kernel - Re: [PATCH 5.13 345/380] KVM: arm64: vgic: move irq->get_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r1dobco8.wl-maz@kernel.org>
Date:   Thu, 16 Sep 2021 19:25:27 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.13 345/380] KVM: arm64: vgic: move irq->get_input_level into an ops structure

On Thu, 16 Sep 2021 17:01:42 +0100,
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> From: Marc Zyngier <maz@...nel.org>
> 
> [ Upstream commit db75f1a33f82ad332b6e139c5960e01999969d2c ]
> 
> We already have the option to attach a callback to an interrupt
> to retrieve its pending state. As we are planning to expand this
> facility, move this callback into its own data structure.
> 
> This will limit the size of individual interrupts as the ops
> structures can be shared across multiple interrupts.
> 
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  arch/arm64/kvm/arch_timer.c |  8 ++++++--
>  arch/arm64/kvm/vgic/vgic.c  | 14 +++++++-------
>  include/kvm/arm_vgic.h      | 28 +++++++++++++++++-----------
>  3 files changed, 30 insertions(+), 20 deletions(-)

As I replied to Sasha earlier, I don't see a good reason to backport
this, as it doesn't improve anything on its own. Unless there is a
compelling reason to get this backported, I'd rather see it dropped.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.