linux-kernel - Re: [PATCH net-next] net: phy: broadcom: Enable 10BaseT DAC early wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210916121003.40327b5d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 16 Sep 2021 12:10:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        bcm-kernel-feedback-list@...adcom.com (open list:BROADCOM ETHERNET PHY
        DRIVERS), linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH net-next] net: phy: broadcom: Enable 10BaseT DAC early
 wake

On Wed, 15 Sep 2021 17:09:03 -0700 Florian Fainelli wrote:
> +	if (phydev->state != PHY_RUNNING)
> +	       return;

checkpatch strikes again, sorry:

WARNING: suspect code indent for conditional statements (8, 15)
#35: FILE: drivers/net/phy/broadcom.c:711:
+	if (phydev->state != PHY_RUNNING)
+	       return;

WARNING: Statements should start on a tabstop
#36: FILE: drivers/net/phy/broadcom.c:712:
+	       return;