linux-kernel - Re: [PATCH] Input: ads7846 - Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Sep 2021 21:34:26 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ads7846 - Make use of the helper function
 dev_err_probe()

On 16/09/2021 17:31, Cai Huoqing wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>  drivers/input/touchscreen/ads7846.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

You sent 32 independent patches. Do you expect us to copy-paste similar
feedback on each of them? This would not make any sense. Please organize
all your submissions in a series with:

  git format-patch -32
  git send-email ..... 00*

The patches you sent were already sent before:
https://lore.kernel.org/lkml/20200827185829.30096-1-krzk@kernel.org/

Best regards,
Krzysztof