linux-kernel - Re: [PATCH] Support for side buttons of Xiaomi Mi Dual Mode Wireless Mouse Silent Edition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Sep 2021 13:00:11 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ilya Skriblovsky <ilyaskriblovsky@...il.com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH] Support for side buttons of Xiaomi Mi Dual Mode Wireless
 Mouse Silent Edition

Hi,

On 9/16/21 12:54 PM, Ilya Skriblovsky wrote:
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 76937f716fbe..d09abc63290e 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -467,6 +467,13 @@ config HID_VIEWSONIC
>   	help
>   	  Support for ViewSonic/Signotec PD1011 signature pad.
>   
> +config HID_XIAOMI:

No ending ':' above.

> +	tristate "Xiaomi"
> +	depends on HID
> +	help
> +	Adds support for side buttons of Xiaomi Mi Dual Mode Wireless
> +	Mouse Silent Edition

End the description with a '.', please.

And the 2 lines of help text should be indented with an extra 2
spaces (although some parts of this Kconfig file are not done
like that and other parts are).

> +

thanks.
-- 
~Randy