linux-kernel - Re: [PATCH] Input: lpc32xx-keys - Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f832f6c-0807-9cfb-f441-6eff820c40e1@mleia.com>
Date:   Thu, 16 Sep 2021 22:58:44 +0300
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: lpc32xx-keys - Make use of the helper function
 dev_err_probe()

Hi Cai,

On 9/16/21 6:33 PM, Cai Huoqing wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>   drivers/input/keyboard/lpc32xx-keys.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/keyboard/lpc32xx-keys.c b/drivers/input/keyboard/lpc32xx-keys.c
> index 943aeeb0de79..12bdf68b8fe7 100644
> --- a/drivers/input/keyboard/lpc32xx-keys.c
> +++ b/drivers/input/keyboard/lpc32xx-keys.c
> @@ -227,10 +227,9 @@ static int lpc32xx_kscan_probe(struct platform_device *pdev)
>   
>   	/* Get the key scanner clock */
>   	kscandat->clk = devm_clk_get(&pdev->dev, NULL);
> -	if (IS_ERR(kscandat->clk)) {
> -		dev_err(&pdev->dev, "failed to get clock\n");
> -		return PTR_ERR(kscandat->clk);
> -	}
> +	if (IS_ERR(kscandat->clk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(kscandat->clk),
> +				     "failed to get clock\n");
>   
>   	/* Configure the key scanner */
>   	error = clk_prepare_enable(kscandat->clk);
> 

thank you for the change!

Acked-by: Vladimir Zapolskiy <vz@...ia.com>

--
Best wishes,
Vladimir