linux-kernel - Re: [PATCH] ARM: select HAVE_FUTEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdmmrxs2eMqvUm+Zg6Lpin+9BoQRPh9CF3Tdnc-+9eeQSw@mail.gmail.com>
Date:   Thu, 16 Sep 2021 16:26:44 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        llvm@...ts.linux.dev, Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Russell King <linux@...linux.org.uk>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        YiFei Zhu <yifeifz2@...inois.edu>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Mike Rapoport <rppt@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>
Subject: Re: [PATCH] ARM: select HAVE_FUTEX_CMPXCHG

On Thu, Sep 16, 2021 at 3:40 PM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Mon, Aug 30, 2021 at 11:38 PM Nick Desaulniers
> <ndesaulniers@...gle.com> wrote:
>
> > tglx notes:
> >   This function [futex_detect_cmpxchg] is only needed when an
> >   architecture has to runtime discover whether the CPU supports it or
> >   not.  ARM has unconditional support for this, so the obvious thing to
> >   do is the below.
> >
> > Fixes linkage failure from Clang randconfigs:
> > kernel/futex.o:(.text.fixup+0x5c): relocation truncated to fit: R_ARM_JUMP24 against `.init.text'
> > and boot failures for CONFIG_THUMB2_KERNEL.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/325
> > Reported-by: Arnd Bergmann <arnd@...db.de>
> > Reported-by: Nathan Chancellor <nathan@...nel.org>
> > Suggested-by: Thomas Gleixner <tglx@...utronix.de>
> > Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
>
> LGTM
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> Please put this into Russell's patch tracker!

Done!
https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9122/1
Thanks for the review!

-- 
Thanks,
~Nick Desaulniers