linux-kernel - Re: [RFC PATCH v2 4/4] sensehat: Add device tree overlay (do not merge)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Sep 2021 12:57:18 +0200
From:   Matthias Brugger <mbrugger@...e.com>
To:     Charles Mirabile <cmirabil@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Serge Schneider <serge@...pberrypi.org>,
        Stefan Wahren <stefan.wahren@...e.com>,
        Nicolas Saenz Julienne <nsaenzju@...hat.com>,
        linux-rpi-kernel@...ts.infradead.org, fedora-rpi@...glegroups.com,
        Mwesigwa Guma <mguma@...hat.com>,
        Joel Savitz <jsavitz@...hat.com>
Subject: Re: [RFC PATCH v2 4/4] sensehat: Add device tree overlay (do not
 merge)

On 20/08/2021 20:08, Charles Mirabile wrote:
> This patch is an RFC. The overlay included here is suitable for the
> Sense HAT but we are not sure where overlays like this should go, or if we
> should even include it, because the Raspberry Pi kernel tree already
> includes that device tree blob that this was based on and most
> distributions for the Raspberry Pi include those blobs.
> 
> The overlay is just in the root of the source tree since we did not know
> where to put it so this patch should not be merged in this state.
> 
> Signed-off-by: Charles Mirabile <cmirabil@...hat.com>
> Signed-off-by: Mwesigwa Guma <mguma@...hat.com>
> Signed-off-by: Joel Savitz <jsavitz@...hat.com>
> ---
>   sensehat.dtbs | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 51 insertions(+)
>   create mode 100644 sensehat.dtbs
> 
> diff --git a/sensehat.dtbs b/sensehat.dtbs
> new file mode 100644
> index 000000000000..3f1c12c8f75f
> --- /dev/null
> +++ b/sensehat.dtbs
> @@ -0,0 +1,51 @@
> +/dts-v1/;
> +
> +/ {
> +	compatible = "brcm,bcm2835";
> +
> +	fragment@0 {
> +		target = <0xffffffff>;
> +
> +		__overlay__ {
> +			#address-cells = <0x01>;
> +			#size-cells = <0x00>;
> +			status = "okay";
> +
> +			sensehat@46 {
> +				compatible = "raspberrypi,sensehat";
> +				reg = <0x46>;
> +				keys-int-gpios = <0xffffffff 0x17 0x01>;
> +				status = "okay";
> +			};
> +
> +			lsm9ds1-magn@1c {
> +				compatible = "st,lsm9ds1-magn";
> +				reg = <0x1c>;
> +				status = "okay";
> +			};
> +
> +			lsm9ds1-accel6a {
> +				compatible = "st,lsm9ds1-accel";
> +				reg = <0x6a>;
> +				status = "okay";
> +			};
> +
> +			lps25h-press@5c {
> +				compatible = "st,lps25h-press";
> +				reg = <0x5c>;
> +				status = "okay";
> +			};
> +
> +			hts221-humid@5f {
> +				compatible = "st,hts221-humid\0st,hts221";

Isn't "st,hts221" good enough?

> +				reg = <0x5f>;
> +				status = "okay";
> +			};
> +		};
> +	};
> +
> +	__fixups__ {
> +		i2c1 = "/fragment@0:target:0";
> +		gpio = "/fragment@..._overlay__/sensehat@46:keys-int-gpios:0";
> +	};
> +};
> 

As Nicolas said, yaml bindings are a must. The overlay can be added as for 
convenience to the series but it should be made clear that it is not supposed to 
be upstreamed.

Regards,
Matthias