linux-kernel - Re: [PATCH 3/7] staging: vchiq_arm: clarify multiplication expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4197af5dfc99650e01bd4aacb776c5be9b795814.camel@perches.com>
Date:   Thu, 16 Sep 2021 04:24:27 -0700
From:   Joe Perches <joe@...ches.com>
To:     Gaston Gonzalez <gascoar@...il.com>, linux-staging@...ts.linux.dev
Cc:     gregkh@...uxfoundation.org, nsaenz@...nel.org,
        stefan.wahren@...e.com, arnd@...db.de, dan.carpenter@...cle.com,
        ojaswin98@...il.com, amarjargal16@...il.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] staging: vchiq_arm: clarify multiplication
 expressions

On Wed, 2021-09-15 at 17:18 -0300, Gaston Gonzalez wrote:
> Add spaces around '*' in multiplication expressions to enhance
> readability.
[]
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
[]
> @@ -466,8 +466,8 @@ int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
>  
>  	g_free_fragments = g_fragments_base;
>  	for (i = 0; i < (MAX_FRAGMENTS - 1); i++) {
> -		*(char **)&g_fragments_base[i*g_fragments_size] =
> -			&g_fragments_base[(i + 1)*g_fragments_size];
> +		*(char **)&g_fragments_base[i * g_fragments_size] =
> +			&g_fragments_base[(i + 1) * g_fragments_size];
>  	}
>  	*(char **)&g_fragments_base[i * g_fragments_size] = NULL;

unrelated:

These '*(char **)&' uses are odd and thankfully rare constructs.