linux-kernel - Re: [PATCH v2] selftests: nci: replace unsigned int with int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACwDmQCbmSo1viWUqUciXUx0jbznPiSj4na+XE2QaD+_B39GWQ@mail.gmail.com>
Date:   Thu, 16 Sep 2021 21:07:47 +0900
From:   Bongsu Jeon <bongsu.jeon2@...il.com>
To:     Xiang wangx <wangxiang@...rlc.com>
Cc:     Bongsu Jeon <bongsu.jeon@...sung.com>, shuah@...nel.org,
        netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests: nci: replace unsigned int with int

I asked you two things.
Please check them below.

On Thu, Sep 16, 2021 at 8:54 PM Xiang wangx <wangxiang@...rlc.com> wrote:
>
> Should not use comparison of unsigned expressions < 0

Please put '.' at the end of the log and add the changelog.
For example
=> Should not use comparison of unsigned expressions < 0.

>
> Signed-off-by: Xiang wangx <wangxiang@...rlc.com>
> ---

Please add the change log here.
For example =>
Changes since v1
* Change commit log

>  tools/testing/selftests/nci/nci_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
> index e1bf55dabdf6..162c41e9bcae 100644
> --- a/tools/testing/selftests/nci/nci_dev.c
> +++ b/tools/testing/selftests/nci/nci_dev.c
> @@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
>                        const __u8 *rsp, __u32 rsp_len)
>  {
>         char buf[256];
> -       unsigned int len;
> +       int len;
>
>         send(nfc_sock, &cmd[3], cmd_len - 3, 0);
>         len = read(virtual_fd, buf, cmd_len);
> --
> 2.20.1
>