lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202109162005.0B2DbkMT-lkp@intel.com>
Date:   Thu, 16 Sep 2021 20:25:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ondrej Mosnacek <omosnace@...hat.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Paul Moore <paul@...l-moore.com>
Subject: [selinuxproject-selinux:stable-5.15 1/1]
 include/linux/rcupdate.h:395:2: error: passing argument 1 of
 'security_locked_down' discards 'const' qualifier from pointer target type

tree:   https://github.com/SELinuxProject/selinux-kernel stable-5.15
head:   c491f0a471580712a4254adece400c3ebb3d8e44
commit: c491f0a471580712a4254adece400c3ebb3d8e44 [1/1] lockdown,selinux: fix wrong subject in some SELinux lockdown checks
config: h8300-buildonly-randconfig-r004-20210916 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/SELinuxProject/selinux-kernel/commit/c491f0a471580712a4254adece400c3ebb3d8e44
        git remote add selinuxproject-selinux https://github.com/SELinuxProject/selinux-kernel
        git fetch --no-tags selinuxproject-selinux stable-5.15
        git checkout c491f0a471580712a4254adece400c3ebb3d8e44
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/rbtree.h:24,
                    from include/linux/mm_types.h:10,
                    from include/linux/buildid.h:5,
                    from include/linux/module.h:14,
                    from fs/debugfs/inode.c:15:
   fs/debugfs/inode.c: In function 'debugfs_setattr':
>> include/linux/rcupdate.h:395:2: error: passing argument 1 of 'security_locked_down' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
     395 | ({ \
         | ~^~~
     396 |         RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_protected() usage"); \
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     397 |         rcu_check_sparse(p, space); \
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     398 |         ((typeof(*p) __force __kernel *)(p)); \
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     399 | })
         | ~~
   include/linux/rcupdate.h:587:9: note: in expansion of macro '__rcu_dereference_protected'
     587 |         __rcu_dereference_protected((p), (c), __rcu)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/cred.h:299:9: note: in expansion of macro 'rcu_dereference_protected'
     299 |         rcu_dereference_protected(current->cred, 1)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~
   fs/debugfs/inode.c:51:44: note: in expansion of macro 'current_cred'
      51 |                 ret = security_locked_down(current_cred(), LOCKDOWN_DEBUGFS);
         |                                            ^~~~~~~~~~~~
   In file included from fs/debugfs/inode.c:29:
   include/linux/security.h:1347:53: note: expected 'struct cred *' but argument is of type 'const struct cred *'
    1347 | static inline int security_locked_down(struct cred *cred, enum lockdown_reason what)
         |                                        ~~~~~~~~~~~~~^~~~
   cc1: all warnings being treated as errors
--
   In file included from include/linux/rbtree.h:24,
                    from include/linux/mm_types.h:10,
                    from include/linux/buildid.h:5,
                    from include/linux/module.h:14,
                    from fs/debugfs/file.c:12:
   fs/debugfs/file.c: In function 'debugfs_locked_down':
>> include/linux/rcupdate.h:395:2: error: passing argument 1 of 'security_locked_down' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
     395 | ({ \
         | ~^~~
     396 |         RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_protected() usage"); \
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     397 |         rcu_check_sparse(p, space); \
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     398 |         ((typeof(*p) __force __kernel *)(p)); \
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     399 | })
         | ~~
   include/linux/rcupdate.h:587:9: note: in expansion of macro '__rcu_dereference_protected'
     587 |         __rcu_dereference_protected((p), (c), __rcu)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/cred.h:299:9: note: in expansion of macro 'rcu_dereference_protected'
     299 |         rcu_dereference_protected(current->cred, 1)
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~
   fs/debugfs/file.c:157:34: note: in expansion of macro 'current_cred'
     157 |         if (security_locked_down(current_cred(), LOCKDOWN_DEBUGFS))
         |                                  ^~~~~~~~~~~~
   In file included from fs/debugfs/file.c:23:
   include/linux/security.h:1347:53: note: expected 'struct cred *' but argument is of type 'const struct cred *'
    1347 | static inline int security_locked_down(struct cred *cred, enum lockdown_reason what)
         |                                        ~~~~~~~~~~~~~^~~~
   cc1: all warnings being treated as errors


vim +395 include/linux/rcupdate.h

76c8eaafe4f061 Paul E. McKenney        2021-04-21  379  
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  380  #define __rcu_access_pointer(p, space) \
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  381  ({ \
7d0ae8086b8283 Paul E. McKenney        2015-03-03  382  	typeof(*p) *_________p1 = (typeof(*p) *__force)READ_ONCE(p); \
423a86a610cad1 Joel Fernandes (Google  2018-12-12  383) 	rcu_check_sparse(p, space); \
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  384  	((typeof(*p) __force __kernel *)(_________p1)); \
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  385  })
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  386  #define __rcu_dereference_check(p, c, space) \
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  387  ({ \
ac59853c06993a Pranith Kumar           2014-11-13  388  	/* Dependency order vs. p above. */ \
506458efaf153c Will Deacon             2017-10-24  389  	typeof(*p) *________p1 = (typeof(*p) *__force)READ_ONCE(p); \
f78f5b90c4ffa5 Paul E. McKenney        2015-06-18  390  	RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_check() usage"); \
423a86a610cad1 Joel Fernandes (Google  2018-12-12  391) 	rcu_check_sparse(p, space); \
ac59853c06993a Pranith Kumar           2014-11-13  392  	((typeof(*p) __force __kernel *)(________p1)); \
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  393  })
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  394  #define __rcu_dereference_protected(p, c, space) \
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28 @395  ({ \
f78f5b90c4ffa5 Paul E. McKenney        2015-06-18  396  	RCU_LOCKDEP_WARN(!(c), "suspicious rcu_dereference_protected() usage"); \
423a86a610cad1 Joel Fernandes (Google  2018-12-12  397) 	rcu_check_sparse(p, space); \
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  398  	((typeof(*p) __force __kernel *)(p)); \
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  399  })
995f1405610bd8 Paul E. McKenney        2016-07-01  400  #define rcu_dereference_raw(p) \
995f1405610bd8 Paul E. McKenney        2016-07-01  401  ({ \
995f1405610bd8 Paul E. McKenney        2016-07-01  402  	/* Dependency order vs. p above. */ \
506458efaf153c Will Deacon             2017-10-24  403  	typeof(p) ________p1 = READ_ONCE(p); \
995f1405610bd8 Paul E. McKenney        2016-07-01  404  	((typeof(*p) __force __kernel *)(________p1)); \
995f1405610bd8 Paul E. McKenney        2016-07-01  405  })
ca5ecddfa8fcbd Paul E. McKenney        2010-04-28  406  

:::::: The code at line 395 was first introduced by commit
:::::: ca5ecddfa8fcbd948c95530e7e817cee9fb43a3d rcu: define __rcu address space modifier for sparse

:::::: TO: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
:::::: CC: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33326 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ