linux-kernel - Re: [PATCH] drm/amd/display: Reduce stack size for dml21

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c709b29-2f1c-aa64-409c-62bcd058f81c@amd.com>
Date:   Thu, 16 Sep 2021 10:34:24 -0400
From:   Leo Li <sunpeng.li@....com>
To:     Harry Wentland <harry.wentland@....com>,
        amd-gfx@...ts.freedesktop.org
Cc:     ndesaulniers@...gle.com, torvalds@...ux-foundation.org,
        linux-kernel@...r.kernel.org, arnd@...nel.org,
        alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, nathan@...nel.org, linux@...ck-us.net,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] drm/amd/display: Reduce stack size for
 dml21_ModeSupportAndSystemConfigurationFull



On 2021-09-14 17:05, Harry Wentland wrote:
> [Why & How]
> With Werror enabled in the kernel we were failing the clang build since
> dml21_ModeSupportAndSystemConfigurationFull's stack frame is 1064 when
> building with clang, and exceeding the default 1024 stack frame limit.
> 
> The culprit seems to be the Pipe struct, so pull the relevant block
> out into its own sub-function.
> 
> Signed-off-by: Harry Wentland<harry.wentland@....com>
> Fixes: 3fe617ccafd6 ("Enable '-Werror' by default for all kernel builds")
> Cc: Nick Desaulniers<ndesaulniers@...gle.com>
> Cc: Linus Torvalds<torvalds@...ux-foundation.org>
> Cc:amd-gfx@...ts.freedesktop.org
> Cc: Linux Kernel Mailing List<linux-kernel@...r.kernel.org>
> Cc: Arnd Bergmann<arnd@...nel.org>
> Cc: Leo Li<sunpeng.li@....com>
> Cc: Alex Deucher<alexander.deucher@....com>
> Cc: Christian König<christian.koenig@....com>
> Cc: Xinhui Pan<Xinhui.Pan@....com>
> Cc: Nathan Chancellor<nathan@...nel.org>
> Cc: Guenter Roeck<linux@...ck-us.net>
> Cc:llvm@...ts.linux.dev
> ---

Reviewed-by: Leo Li <sunpeng.li@....com>