linux-kernel - [PATCH] Input: mms114 - Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210916153326.14734-1-caihuoqing@baidu.com>
Date:   Thu, 16 Sep 2021 23:33:25 +0800
From:   Cai Huoqing <caihuoqing@...du.com>
To:     <caihuoqing@...du.com>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] Input: mms114 - Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
---
 drivers/input/touchscreen/mms114.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c
index 9fa3b0e421be..4b36db084d86 100644
--- a/drivers/input/touchscreen/mms114.c
+++ b/drivers/input/touchscreen/mms114.c
@@ -525,20 +525,14 @@ static int mms114_probe(struct i2c_client *client,
 	i2c_set_clientdata(client, data);
 
 	data->core_reg = devm_regulator_get(&client->dev, "avdd");
-	if (IS_ERR(data->core_reg)) {
-		error = PTR_ERR(data->core_reg);
-		dev_err(&client->dev,
-			"Unable to get the Core regulator (%d)\n", error);
-		return error;
-	}
+	if (IS_ERR(data->core_reg))
+		return dev_err_probe(&client->dev, PTR_ERR(data->core_reg),
+				     "Unable to get the Core regulator\n");
 
 	data->io_reg = devm_regulator_get(&client->dev, "vdd");
-	if (IS_ERR(data->io_reg)) {
-		error = PTR_ERR(data->io_reg);
-		dev_err(&client->dev,
-			"Unable to get the IO regulator (%d)\n", error);
-		return error;
-	}
+	if (IS_ERR(data->io_reg))
+		return dev_err_probe(&client->dev, PTR_ERR(data->io_reg),
+				     "Unable to get the IO regulator\n");
 
 	error = devm_request_threaded_irq(&client->dev, client->irq,
 					  NULL, mms114_interrupt,
-- 
2.25.1