lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Sep 2021 23:34:17 +0800 From: Cai Huoqing <caihuoqing@...du.com> To: <caihuoqing@...du.com> CC: Dmitry Torokhov <dmitry.torokhov@...il.com>, Orson Zhai <orsonzhai@...il.com>, Baolin Wang <baolin.wang7@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>, <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: [PATCH] Input: sc27xx-vibra - Make use of the helper function dev_err_probe() When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing <caihuoqing@...du.com> --- drivers/input/misc/sc27xx-vibra.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/input/misc/sc27xx-vibra.c b/drivers/input/misc/sc27xx-vibra.c index 1478017f0968..7cf0a1354320 100644 --- a/drivers/input/misc/sc27xx-vibra.c +++ b/drivers/input/misc/sc27xx-vibra.c @@ -135,10 +135,9 @@ static int sc27xx_vibra_probe(struct platform_device *pdev) } error = device_property_read_u32(&pdev->dev, "reg", &info->base); - if (error) { - dev_err(&pdev->dev, "failed to get vibrator base address.\n"); - return error; - } + if (error) + return dev_err_probe(&pdev->dev, error, + "failed to get vibrator base address.\n"); info->input_dev = devm_input_allocate_device(&pdev->dev); if (!info->input_dev) { -- 2.25.1
Powered by blists - more mailing lists