linux-kernel - Re: [PATCH 1/1] Smack:- Use overlay inode label in smack_inode_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12b65513-3f70-7d77-d8b7-8aae82c9041a@schaufler-ca.com>
Date:   Fri, 17 Sep 2021 09:32:08 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     Vishal Goel <vishal.goel@...sung.com>,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     a.sahrawat@...sung.com, v.narang@...sung.com,
        Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH 1/1] Smack:- Use overlay inode label in
 smack_inode_copy_up()

On 9/17/2021 12:38 AM, Vishal Goel wrote:
> Currently in "smack_inode_copy_up()" function, process label is
> changed with the label on parent inode. Due to which,
> process is assigned directory label and whatever file or directory
> created by the process are also getting directory label
> which is wrong label.
>
> Changes has been done to use label of overlay inode instead
> of parent inode.

Do you have a test case for this change?

>
> Signed-off-by: Vishal Goel <vishal.goel@...sung.com>
> ---
>  security/smack/smack_lsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index cacbe7518..91e50e5cb 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -4634,7 +4634,7 @@ static int smack_inode_copy_up(struct dentry *dentry, struct cred **new)
>  	/*
>  	 * Get label from overlay inode and set it in create_sid
>  	 */
> -	isp = smack_inode(d_inode(dentry->d_parent));
> +	isp = smack_inode(d_inode(dentry));
>  	skp = isp->smk_inode;
>  	tsp->smk_task = skp;
>  	*new = new_creds;