lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Fri, 17 Sep 2021 10:34:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     kbuild-all@...ts.01.org, Daniel Borkmann <daniel@...earbox.net>,
        linux-kernel@...r.kernel.org
Subject: [dborkman-bpf:pr/bpf-tstamp 3/3] include/net/tcp.h:812:25: error:
 'const struct sk_buff' has no member named 'skb_mstamp_ns'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git pr/bpf-tstamp
head:   f7d619a946e981177777983af26e9e31163ffb38
commit: f7d619a946e981177777983af26e9e31163ffb38 [3/3] net: skb clock bases
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git/commit/?id=f7d619a946e981177777983af26e9e31163ffb38
        git remote add dborkman-bpf https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/bpf.git
        git fetch --no-tags dborkman-bpf pr/bpf-tstamp
        git checkout f7d619a946e981177777983af26e9e31163ffb38
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from net/core/sock.c:139:
   include/net/tcp.h: In function 'tcp_skb_timestamp':
>> include/net/tcp.h:812:25: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     812 |  return tcp_ns_to_ts(skb->skb_mstamp_ns);
         |                         ^~
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:818:20: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     818 |  return div_u64(skb->skb_mstamp_ns, NSEC_PER_USEC);
         |                    ^~
   include/net/tcp.h: In function 'tcp_add_tx_delay':
>> include/net/tcp.h:2367:6: error: 'struct sk_buff' has no member named 'skb_mstamp_ns'
    2367 |   skb->skb_mstamp_ns += (u64)tp->tcp_tx_delay * NSEC_PER_USEC;
         |      ^~
--
   In file included from net/ipv4/route.c:101:
   include/net/tcp.h: In function 'tcp_skb_timestamp':
>> include/net/tcp.h:812:25: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     812 |  return tcp_ns_to_ts(skb->skb_mstamp_ns);
         |                         ^~
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:818:20: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     818 |  return div_u64(skb->skb_mstamp_ns, NSEC_PER_USEC);
         |                    ^~
   include/net/tcp.h: In function 'tcp_add_tx_delay':
>> include/net/tcp.h:2367:6: error: 'struct sk_buff' has no member named 'skb_mstamp_ns'
    2367 |   skb->skb_mstamp_ns += (u64)tp->tcp_tx_delay * NSEC_PER_USEC;
         |      ^~
   net/ipv4/route.c: In function 'ip_rt_send_redirect':
   net/ipv4/route.c:877:6: warning: variable 'log_martians' set but not used [-Wunused-but-set-variable]
     877 |  int log_martians;
         |      ^~~~~~~~~~~~
--
   In file included from net/ipv4/tcp.c:274:
   include/net/tcp.h: In function 'tcp_skb_timestamp':
>> include/net/tcp.h:812:25: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     812 |  return tcp_ns_to_ts(skb->skb_mstamp_ns);
         |                         ^~
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:818:20: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     818 |  return div_u64(skb->skb_mstamp_ns, NSEC_PER_USEC);
         |                    ^~
   include/net/tcp.h: In function 'tcp_add_tx_delay':
>> include/net/tcp.h:2367:6: error: 'struct sk_buff' has no member named 'skb_mstamp_ns'
    2367 |   skb->skb_mstamp_ns += (u64)tp->tcp_tx_delay * NSEC_PER_USEC;
         |      ^~
   net/ipv4/tcp.c: In function 'tcp_get_timestamping_opt_stats':
>> net/ipv4/tcp.c:3901:48: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
    3901 |  nla_put_u64_64bit(stats, TCP_NLA_EDT, orig_skb->skb_mstamp_ns,
         |                                                ^~
--
   In file included from net/ipv4/tcp_input.c:74:
   include/net/tcp.h: In function 'tcp_skb_timestamp':
>> include/net/tcp.h:812:25: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     812 |  return tcp_ns_to_ts(skb->skb_mstamp_ns);
         |                         ^~
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:818:20: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     818 |  return div_u64(skb->skb_mstamp_ns, NSEC_PER_USEC);
         |                    ^~
   include/net/tcp.h: In function 'tcp_add_tx_delay':
>> include/net/tcp.h:2367:6: error: 'struct sk_buff' has no member named 'skb_mstamp_ns'
    2367 |   skb->skb_mstamp_ns += (u64)tp->tcp_tx_delay * NSEC_PER_USEC;
         |      ^~
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:819:1: error: control reaches end of non-void function [-Werror=return-type]
     819 | }
         | ^
   include/net/tcp.h: In function 'tcp_skb_timestamp':
   include/net/tcp.h:813:1: error: control reaches end of non-void function [-Werror=return-type]
     813 | }
         | ^
   cc1: some warnings being treated as errors
--
   In file included from net/ipv4/tcp_output.c:40:
   include/net/tcp.h: In function 'tcp_skb_timestamp':
>> include/net/tcp.h:812:25: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     812 |  return tcp_ns_to_ts(skb->skb_mstamp_ns);
         |                         ^~
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:818:20: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     818 |  return div_u64(skb->skb_mstamp_ns, NSEC_PER_USEC);
         |                    ^~
   include/net/tcp.h: In function 'tcp_add_tx_delay':
>> include/net/tcp.h:2367:6: error: 'struct sk_buff' has no member named 'skb_mstamp_ns'
    2367 |   skb->skb_mstamp_ns += (u64)tp->tcp_tx_delay * NSEC_PER_USEC;
         |      ^~
   net/ipv4/tcp_output.c: In function 'tcp_make_synack':
>> net/ipv4/tcp_output.c:3564:32: error: expected ';' before 'if'
    3564 |   skb_set_tstamp_mono(skb, now)
         |                                ^
         |                                ;
    3565 |   if (!tcp_rsk(req)->snt_synack) /* Timestamp first SYNACK */
         |   ~~                            
   net/ipv4/tcp_output.c: In function 'tcp_send_syn_data':
>> net/ipv4/tcp_output.c:3790:35: error: 'struct sk_buff' has no member named 'skb_mstamp_ns'
    3790 |  skb_set_tstamp_mono(syn, syn_data->skb_mstamp_ns);
         |                                   ^~
   In file included from net/ipv4/tcp_output.c:40:
   include/net/tcp.h: In function 'tcp_skb_timestamp':
   include/net/tcp.h:813:1: error: control reaches end of non-void function [-Werror=return-type]
     813 | }
         | ^
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:819:1: error: control reaches end of non-void function [-Werror=return-type]
     819 | }
         | ^
   cc1: some warnings being treated as errors
--
   In file included from net/ipv4/tcp_ipv4.c:64:
   include/net/tcp.h: In function 'tcp_skb_timestamp':
>> include/net/tcp.h:812:25: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     812 |  return tcp_ns_to_ts(skb->skb_mstamp_ns);
         |                         ^~
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:818:20: error: 'const struct sk_buff' has no member named 'skb_mstamp_ns'
     818 |  return div_u64(skb->skb_mstamp_ns, NSEC_PER_USEC);
         |                    ^~
   include/net/tcp.h: In function 'tcp_add_tx_delay':
>> include/net/tcp.h:2367:6: error: 'struct sk_buff' has no member named 'skb_mstamp_ns'
    2367 |   skb->skb_mstamp_ns += (u64)tp->tcp_tx_delay * NSEC_PER_USEC;
         |      ^~
   include/net/tcp.h: In function 'tcp_skb_timestamp_us':
   include/net/tcp.h:819:1: error: control reaches end of non-void function [-Werror=return-type]
     819 | }
         | ^
   cc1: some warnings being treated as errors


vim +812 include/net/tcp.h

^1da177e4c3f415 Linus Torvalds 2005-04-16  809  
7faee5c0d514162 Eric Dumazet   2014-09-05  810  static inline u32 tcp_skb_timestamp(const struct sk_buff *skb)
7faee5c0d514162 Eric Dumazet   2014-09-05  811  {
200ecef67b8d09d Eric Dumazet   2019-11-07 @812  	return tcp_ns_to_ts(skb->skb_mstamp_ns);
7faee5c0d514162 Eric Dumazet   2014-09-05  813  }
7faee5c0d514162 Eric Dumazet   2014-09-05  814  

:::::: The code at line 812 was first introduced by commit
:::::: 200ecef67b8d09d16ec55f91c92751dcc7a38d40 tcp: Remove one extra ktime_get_ns() from cookie_init_timestamp

:::::: TO: Eric Dumazet <edumazet@...gle.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (9602 bytes)

Powered by blists - more mailing lists