linux-kernel - Re: [PATCH 1/4] gpio/rockchip: extended debounce support is only available on v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZQLxpk5XYOnD3p5s6xAsNbUjTJ4PsMq1bvxVjdMepf+A@mail.gmail.com>
Date:   Sat, 18 Sep 2021 00:34:45 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] gpio/rockchip: extended debounce support is only
 available on v2

On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner <heiko@...ech.de> wrote:

> The gpio driver runs into issues on v1 gpio blocks, as the db_clk
> and the whole extended debounce support is only ever defined on v2.
> So checking for the IS_ERR on the db_clk is not enough, as it will
> be NULL on v1.
>
> Fix this by adding the needed condition for v2 first before checking
> the existence of the db_clk.
>
> This caused my rk3288-veyron-pinky to enter a reboot loop when it
> tried to enable the power-key as adc-key device.
>
> Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
This can be applied by Bartosz to the GPIO subsystem.

Yours,
Linus Walleij