linux-kernel - Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f2b77a5-e2a8-71a5-1b32-3ca2944cad28@socionext.com>
Date:   Sat, 18 Sep 2021 08:48:46 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Pali Rohár <pali@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking

Hi Marc,

Thank you for your comment.

On 2021/09/17 22:54, Marc Zyngier wrote:
> On Thu, 16 Sep 2021 12:30:52 +0100,
> Kunihiko Hayashi <hayashi.kunihiko@...ionext.com> wrote:
>>
>> Gentle ping, are there any comments about this series?
>>
>> Thank you,
>>
>> On 2021/08/30 11:22, Kunihiko Hayashi wrote:
>>> This series includes some fixes to INTx masking/unmasking for UniPhier PCIe
>>> host controller driver.
>>>
>>> - Remove unnecessary bit clears to INTX mask field
>>> - Remove unnecessary irq_ack() function because write access to status field
>>>     doesn't work
>>> - Add lock into callback functions to avoid race condition
>>>
>>> Kunihiko Hayashi (2):
>>>     PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack
>>>       function
>>>     PCI: uniphier: Serialize INTx masking/unmasking
>>>
>>>    drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++----------------
>>>    1 file changed, 10 insertions(+), 16 deletions(-)
>>>
> 
> Patches look OK, although I would personally squash them into a single
> one (INTx masking never really worked before that). FWIW:

Surely applying only the first patch leaves the issue with the second one.
I'll squash them in v3.

Thank you,

> 
> Acked-by: Marc Zyngier <maz@...nel.org>
> 
> 	N,
> 

---
Best Regards
Kunihiko Hayashi