linux-kernel - Re: [PATCH 3/3] csky: Make HAVE_TCM depend on !COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTSqKZKnUw-UQt5Tiag3T0D04dBW9FijaxPX7Q985=+j7w@mail.gmail.com>
Date:   Fri, 17 Sep 2021 14:19:53 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     linux-csky@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] csky: Make HAVE_TCM depend on !COMPILE_TEST

Acked, thx. It'll in next-tree.

On Fri, Sep 17, 2021 at 12:38 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> Building csky:allmodconfig results in the following build errors.
>
> arch/csky/mm/tcm.c:9:2: error:
>                 #error "You should define ITCM_RAM_BASE"
>     9 | #error "You should define ITCM_RAM_BASE"
>       |  ^~~~~
> arch/csky/mm/tcm.c:14:2: error:
>                 #error "You should define DTCM_RAM_BASE"
>    14 | #error "You should define DTCM_RAM_BASE"
>       |  ^~~~~
> arch/csky/mm/tcm.c:18:2: error:
>                 #error "You should define correct DTCM_RAM_BASE"
>    18 | #error "You should define correct DTCM_RAM_BASE"
>
> This is seen with compile tests since those enable HAVE_TCM,
> but do not provide useful default values for ITCM_RAM_BASE or
> DTCM_RAM_BASE. Disable HAVE_TCM for commpile tests to avoid
> the error.
>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  arch/csky/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> index 58ca3ef02bab..823d3d5a9e11 100644
> --- a/arch/csky/Kconfig
> +++ b/arch/csky/Kconfig
> @@ -241,6 +241,7 @@ endchoice
>
>  menuconfig HAVE_TCM
>         bool "Tightly-Coupled/Sram Memory"
> +       depends on !COMPILE_TEST
>         help
>           The implementation are not only used by TCM (Tightly-Coupled Meory)
>           but also used by sram on SOC bus. It follow existed linux tcm
> --
> 2.33.0
>


-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/