linux-kernel - Re: [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acb72aa2-4211-4c2f-1176-82d533ddf8b5@samsung.com>
Date:   Fri, 17 Sep 2021 09:30:34 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFT][PATCH] regulator: max14577: Revert
 "regulator: max14577: Add proper module aliases strings"

Hi Krzysztof,

On 16.09.2021 16:41, Krzysztof Kozlowski wrote:
> This reverts commit 0da6736ecd10b45e535b100acd58df2db4c099d8.
>
> The MODULE_DEVICE_TABLE already creates proper alias.  Having another
> MODULE_ALIAS causes the alias to be duplicated:
>
>    $ modinfo max14577-regulator.ko
>
>    alias:          platform:max77836-regulator
>    alias:          platform:max14577-regulator
>    description:    Maxim 14577/77836 regulator driver
>    alias:          platform:max77836-regulator
>    alias:          platform:max14577-regulator
>
> Cc: Marek Szyprowski <m.szyprowski@...sung.com>
> Fixes: 0da6736ecd10 ("regulator: max14577: Add proper module aliases strings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>
> ---
>
> Not tested. Please test/comment.  This is an RFT also because reverted
> commit said to fix autoloading issue which I even reviewed... but really
> it should not be needed - alias gets duplicated.
> ---

Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>

Indeed, that patch was useless and excessive. It must be some leftover 
from my initial modules tests, which for good reasons was not submitted 
in the initial series in Feb 2020. Sorry for the noise.

>   drivers/regulator/max14577-regulator.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c
> index 1d78b455cc48..e34face736f4 100644
> --- a/drivers/regulator/max14577-regulator.c
> +++ b/drivers/regulator/max14577-regulator.c
> @@ -269,5 +269,3 @@ module_exit(max14577_regulator_exit);
>   MODULE_AUTHOR("Krzysztof Kozlowski <krzk@...nel.org>");
>   MODULE_DESCRIPTION("Maxim 14577/77836 regulator driver");
>   MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:max14577-regulator");
> -MODULE_ALIAS("platform:max77836-regulator");

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland