linux-kernel - Re: [PATCH v5 4/6] drivers: iio: dac: ad5766: Fix dt property name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+U=Dsrm8daPO+0gob1USqSSxrkpCwR=L-2zQrW=DNEDk9ZhLA@mail.gmail.com>
Date:   Fri, 17 Sep 2021 10:53:54 +0300
From:   Alexandru Ardelean <ardeleanalex@...il.com>
To:     Mihail Chindris <mihail.chindris@...log.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Nuno Sá <nuno.sa@...log.com>,
        "Bogdan, Dragos" <dragos.bogdan@...log.com>
Subject: Re: [PATCH v5 4/6] drivers: iio: dac: ad5766: Fix dt property name

On Fri, Sep 17, 2021 at 9:11 AM Mihail Chindris
<mihail.chindris@...log.com> wrote:
>
> In the documentation the name for the property is
> output-range-microvolts which is a standard name, therefore this name
> must be used.
>

This requires a Fixes tag.
With that addressed:

Reviewed-by: Alexandru Ardelean <ardeleanalex@...il.com>

> Signed-off-by: Mihail Chindris <mihail.chindris@...log.com>
> ---
>  drivers/iio/dac/ad5766.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/dac/ad5766.c b/drivers/iio/dac/ad5766.c
> index 3104ec32dfac..dafda84fdea3 100644
> --- a/drivers/iio/dac/ad5766.c
> +++ b/drivers/iio/dac/ad5766.c
> @@ -503,13 +503,13 @@ static int ad5766_get_output_range(struct ad5766_state *st)
>         int i, ret, min, max, tmp[2];
>
>         ret = device_property_read_u32_array(&st->spi->dev,
> -                                            "output-range-voltage",
> +                                            "output-range-microvolts",
>                                              tmp, 2);
>         if (ret)
>                 return ret;
>
> -       min = tmp[0] / 1000;
> -       max = tmp[1] / 1000;
> +       min = tmp[0] / 1000000;
> +       max = tmp[1] / 1000000;
>         for (i = 0; i < ARRAY_SIZE(ad5766_span_tbl); i++) {
>                 if (ad5766_span_tbl[i].min != min ||
>                     ad5766_span_tbl[i].max != max)
> --
> 2.27.0
>