linux-kernel - Re: [PATCH v2] extcon: extcon-axp288: use P-Unit semaphore lock for register accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210917080426.GA1410@agape.jhs>
Date:   Fri, 17 Sep 2021 10:04:27 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] extcon: extcon-axp288: use P-Unit semaphore lock for
 register accesses

Hello Hans,

On Thu, Sep 16, 2021 at 01:12:53PM +0200, Hans de Goede wrote:
> Hi,
<snip>
> > 
> > Suggested-by: Hans de Goede <hdegoede@...hat.com>
> > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> > Tested-by: Hans de Goede <hdegoede@...hat.com>
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@...il.com>
> > ---
> > Changes in v2:
> > 	- shortened patch title within 75 char
> > 	- added return value check in function
> > 	  iosf_mbi_lock_punit_i2c_access() calls
> 
> 
> Actually your last version was v2, so this one should have
> been v3 (no need to resend it just for that).

oh sorry for mistake

> 
> Other then that remark this looks good, thank you.

thank you for review

> 
> Regards,
> 
> Hans

@Chanwoo, do you need for me to resend a v3 or
you can take the patch as-is?

thank you,

fabio